Cd removal from new VM page #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The translations were previously erroneously based on backend class VMStatus instead of REST class VmStatus.
Previously enum translation threw an exception in case of unknown enum or unknow enum member. Now the enum item name is returned and problem is logged to browser console.
bond95
reviewed
Feb 21, 2018
src/components/VmDialog/index.js
Outdated
| @@ -33,6 +33,7 @@ import SelectBox from '../SelectBox' | |||
| import { MAX_VM_MEMORY_FACTOR } from '../../constants/index' | |||
|
|
|||
| import { msg } from '../../intl' | |||
| import { Fragment } from '../utils' | |||
There was a problem hiding this comment.
Can we use React.Fragment instead of creating new component?
There was a problem hiding this comment.
We would need to upgrade to React 16 to use native React.Fragment which is not wanted before 4.2 oVirt release.
There was a problem hiding this comment.
Unfortunately (props) => props.children only works since React 16.0. So I resorted to <div> wrapper.
Problem: If a new VM was based on a template with disks then `createNewVm` saga first sent a request to create a VM which was immediately locked for the time of disk image copying. Then the saga fired a request to set a CD image. However the request failed because the VM was locked. Solution: CD image can no longer be customized from New VM page, it is possible only from Edit VM page.
mareklibra
approved these changes
Feb 26, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only last commit is relevant. Please try to merge #495 first.
This change is