Pass "?locale" URL query param to oVirt API

[mareklibra]

With this change, the oVirt API returns localized error messages, so
they can be displayed to the user without additional modification.

Fixes: #110

---

This change is 

[mareklibra]

@jelkosz , please try.
Works for me :-)

[mareklibra]

Blocked by missing translations in oVirt API.
Or until different approach is found.

[jelkosz]

@mareklibra it is not blocked anymore, we can normally use the ?locale=en_US or whatever now and it will work.

[mareklibra]

Needs rebase

[jniederm]

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

---

src/config.js, line 18 at r1 (raw file):

function parseQueryParams () {
  AppConfiguration.queryParams.locale = getURLQueryParameterByName('locale')

Maybe we can unify locale resolution with intl module:

import intl from 'intl'
AppConfiguration.queryParams.locale = intl.locale

or use intl module directly in ovirtapi.js

---

src/helpers.js, line 98 at r1 (raw file):

}

export function getURLQueryParameterByName (name, url) {

Is there any need for url argument? I can't it to be used.

How about getUrlQueryParameterByName instead of getURLQueryParameterByName?

---

src/helpers.js, line 100 at r1 (raw file):

export function getURLQueryParameterByName (name, url) {
  if (!url) {
    url = window.location.href

for http://example.com/page?hello=world&foo=bar window.location.search returns ?hello=world&foo=bar. Maybe search property can be used.

---

Comments from Reviewable

[mareklibra]

Do logging of result here

[mareklibra]

Rebased

[mareklibra]

Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions.

---

src/config.js, line 18 at r1 (raw file):

Previously, jniederm wrote…

Maybe we can unify locale resolution with intl module:

import intl from 'intl'
AppConfiguration.queryParams.locale = intl.locale

or use intl module directly in ovirtapi.js

good point, but let's postpone that for a follow-up due to time constraints. Must be properly verified against engine side due to potential differences (i.e. '-' vs '_' or different browser locale)

---

src/helpers.js, line 98 at r1 (raw file):

Previously, jniederm wrote…

Is there any need for url argument? I can't it to be used.

How about getUrlQueryParameterByName instead of getURLQueryParameterByName?

Not anymore, removed

---

src/helpers.js, line 100 at r1 (raw file):

Previously, jniederm wrote…

for http://example.com/page?hello=world&foo=bar window.location.search returns ?hello=world&foo=bar. Maybe search property can be used.

Good point, but this works as well.

---

src/helpers.js, line 113 at r1 (raw file):

Previously, mareklibra (Marek Libra) wrote…

Do logging of result here

Done.

---

Comments from Reviewable

[jniederm]

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

---

src/config.js, line 18 at r1 (raw file):

Previously, mareklibra (Marek Libra) wrote…

good point, but let's postpone that for a follow-up due to time constraints. Must be properly verified against engine side due to potential differences (i.e. '-' vs '_' or different browser locale)

based on offline communication: consumers are different: web-ui localization vs Accept-Language header for REST API.

---

Comments from Reviewable