Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_engine: Ignore errors on downgrade #172

Merged
merged 3 commits into from
Jun 1, 2022

Conversation

tinez
Copy link
Member

@tinez tinez commented Jun 1, 2022

Signed-off-by: Marcin Sobczyk [email protected]

@tinez tinez requested a review from erav June 1, 2022 09:29
@tinez
Copy link
Member Author

tinez commented Jun 1, 2022

/ost

@erav
Copy link
Member

erav commented Jun 1, 2022

concise but difficult to understand why this syntax is used.

@@ -44,5 +44,5 @@ gpgcheck=0
enabled=1
EOF
dnf downgrade -y --repo fast-datapath ovn-2021-central-21.12.0-46.el8fdp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please use --repofrompath instead?

@michalskrivanek
Copy link
Member

how about this?

@michalskrivanek
Copy link
Member

/ost

@michalskrivanek
Copy link
Member

/ost

1 similar comment
@michalskrivanek
Copy link
Member

/ost

@erav erav self-requested a review June 1, 2022 09:50
@michalskrivanek
Copy link
Member

/ost

@michalskrivanek michalskrivanek merged commit 0f4d169 into master Jun 1, 2022
@michalskrivanek michalskrivanek deleted the ignore-errors-on-downgrade branch June 1, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants