Examples: fix show_summary and add check_OCP_support #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the oVirt Engine version is not showed correctly. This patch adds .MustFullVersion(). Signed-off-by: Douglas Schilling Landgraf <[email protected]>
|
Before the patch: After the patch: |
Add example how to parse engine versions and check if OCP deploy is supported. Signed-off-by: Douglas Schilling Landgraf <[email protected]>
dougsland
changed the title
|
Looks good to me. Let's merge it. Thank you very much @dougsland . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Douglas Schilling Landgraf [email protected]
Benefits
Possible Drawbacks
None
Verification Process
Locally tested
Applicable Issues
Show users how the bits works.