Detect dominant language type #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems a bit overkill in terms of the added number of dependencies, but it does the job... thanks. |
|
Yeah, I might have a look sometimes, how tokei or loc do their analysis and maybe extract the relevant code, so it is not as big dependency. The reason I decided to go with this, it tokei had quite nice library api next to their command line utility, so I used that. |
Mouvedia
reviewed
Dec 15, 2018
| tokei::LanguageType::Haskell => Language::Haskell, | ||
| tokei::LanguageType::Ruby => Language::Ruby, | ||
| tokei::LanguageType::R => Language::R, | ||
| _ => unimplemented!(), |
There was a problem hiding this comment.
JavaScript is a valid LanguageType.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This detects language of source code repository at runtime.
Fixes #1