Add JSON Output Support #337

HallerPatrick · 2020-12-08T13:04:26Z

Issue: #302

…tation of onefetch output

…it_utils functions for more granual information for json

spenserblack

Thanks for your work on this!

Left a few notes.

src/onefetch/cli.rs

src/onefetch/info.rs

src/onefetch/git_utils.rs

… string concat to format macro in git_utils

src/onefetch/cli.rs

Unwrap a "always Some" format args Co-authored-by: Spenser Black <[email protected]>

…to master

HallerPatrick · 2020-12-09T00:39:43Z

This Review feature is amazing! Thank you for your time to look over my code @spenserblack .

spenserblack

Thank you for your hard work, @HallerPatrick!

joseluisq · 2020-12-09T20:18:45Z

Awesome! 👍

HallerPatrick added 3 commits December 7, 2020 15:06

Implementation of json flag, wich allows to print out a json represen…

65c7a54

…tation of onefetch output

Commit of missing changes of last commit

9993dcb

Custom impl of serializer for Info struct, also some refactoring of g…

33ec3cd

…it_utils functions for more granual information for json

spenserblack reviewed Dec 8, 2020

View reviewed changes

src/onefetch/cli.rs Outdated Show resolved Hide resolved

src/onefetch/info.rs Outdated Show resolved Hide resolved

src/onefetch/git_utils.rs Outdated Show resolved Hide resolved

Removed serde_test, use of format flag instead of json flag, chang of…

219190b

… string concat to format macro in git_utils

spenserblack reviewed Dec 8, 2020

View reviewed changes

src/onefetch/cli.rs Outdated Show resolved Hide resolved

src/onefetch/cli.rs Outdated Show resolved Hide resolved

HallerPatrick and others added 3 commits December 9, 2020 01:31

Update src/onefetch/cli.rs

9cb465c

Unwrap a "always Some" format args Co-authored-by: Spenser Black <[email protected]>

Using possible_values instead of validator for format arg

2e3760a

Merge branch 'master' of https://github.com/HallerPatrick/onefetch in…

ffcb73e

…to master

spenserblack approved these changes Dec 9, 2020

View reviewed changes

o2sh merged commit 4be57b5 into o2sh:master Dec 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add JSON Output Support #337

Add JSON Output Support #337

HallerPatrick commented Dec 8, 2020

spenserblack left a comment

HallerPatrick commented Dec 9, 2020 •

edited

Loading

spenserblack left a comment

joseluisq commented Dec 9, 2020

Add JSON Output Support #337

Add JSON Output Support #337

Conversation

HallerPatrick commented Dec 8, 2020

spenserblack left a comment

Choose a reason for hiding this comment

HallerPatrick commented Dec 9, 2020 • edited Loading

spenserblack left a comment

Choose a reason for hiding this comment

joseluisq commented Dec 9, 2020

HallerPatrick commented Dec 9, 2020 •

edited

Loading