RFC: generalized expression framework #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabrizio-m
approved these changes
Aug 16, 2023
joseandro
approved these changes
Aug 16, 2023
|
|
||
| In particular, the requirements are that zkVM instructions can be encoded as an expressionunder the framework, without modifying or otherwise affecting the expressions used for the berkeley specialization of the kimchi framework. | ||
|
|
||
| We can measure progress towards this goal by executing an intermediate task. The 'cairo gates' defined in the kimchi proof system are currently unused in berkeley, but the selectors for these gates are [hard-coded in the list used for the berkeley expressions](https://github.com/o1-labs/proof-systems/blob/17041948eb2742244464d6749560a304213f4198/kimchi/src/circuits/gate.rs#L102); when this RFC is successfully implemented, it should be possible to define those constraints over a cairo-specific set of columns, which in turn will allow those variants to be removed. |
There was a problem hiding this comment.
We have the following Cairo gate selectors:
CairoClaim,
CairoInstruction,
CairoFlags,
CairoTransition,
Are there other impacts to the berkeley kimchi proof system if we end up removing these selectors?
bkase
approved these changes
Aug 17, 2023
5 tasks
Co-authored-by: Joseandro Luiz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.