Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circuit interface to create Keccak gadget #1268

Merged
merged 21 commits into from
Nov 14, 2023
Merged

Conversation

querolita
Copy link
Member

Closes #1219 #1220

@querolita querolita force-pushed the zkvm/keccak/circuit branch from 5c42ebd to 1e23d22 Compare October 19, 2023 10:18
@querolita querolita force-pushed the zkvm/keccak/circuit branch from 355f2a8 to 8236952 Compare October 20, 2023 11:15
Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except having small unit tests and nit comments on documentation and variable naming.

4qjnyaegv7ly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mechanism to divide message into blocks without copy constraints
2 participants