Keccak gates for zkVM
#1244
Merged
Keccak gates for zkVM
#1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querolita
changed the base branch from
fabrizio-m/abstract-column
to
fabrizio-m/abstract-get-column
querolita
changed the base branch from
fabrizio-m/abstract-get-column
to
zkvm/keccak/lookup-table
querolita
force-pushed
the
zkvm/keccak/lookup-table
branch
from
74cd60a to
2a82e2d
Compare
querolita
force-pushed
the
zkvm/keccak/gate
branch
from
3b3905e to
37e99e4
Compare
5 tasks
querolita
force-pushed
the
zkvm/keccak/gate
branch
from
5f5aeaa to
431d562
Compare
dannywillems
reviewed
Nov 3, 2023
dannywillems
reviewed
Nov 3, 2023
dannywillems
reviewed
Nov 3, 2023
dannywillems
reviewed
Nov 3, 2023
dannywillems
reviewed
Nov 3, 2023
Co-authored-by: Danny Willems <[email protected]>
dannywillems
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Keccak gate as suggested in the RFC.
It contains the constraints and layout of the initial state XOR and the permutation round itself. The witness generation code will come in a subsequent PR.
Closes
#1214
#1215
#1216
#1217
#1222
#1225