Clean-up indirect dependencies #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarama was causing some other indirect dependencies. Upgrading it fixes the issue. We now have 3 indirect dependencies listed in go.mod: - github.com/go-logfmt/logfmt - github.com/go-stack/stack - gopkg.in/jcmturner/goidentity.v3 go-kit accounts for the first two and sarama for the last one. Since sarama does support go modules, this may be something missing on their side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sarama v1.20.1 was causing some other indirect dependencies.
Upgrading it to a version that uses support go modules fixes
the "issue".
We now have 3 indirect dependencies listed in go.mod:
go-kit accounts for the first two and sarama for the last one. Since
sarama does support go modules, this may be something missing on their
side.
go-kit simply doesn't use go modules to specify their dependencies, so we'll
have to live with that one.