-
Notifications
You must be signed in to change notification settings - Fork 383
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Nullability and lightweight generics annotations on NYTPhotosOverlayView
- Loading branch information
Showing
1 changed file
with
12 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,8 +8,10 @@ | |
|
||
@import UIKit; | ||
|
||
NS_ASSUME_NONNULL_BEGIN | ||
|
||
/** | ||
* A view that overlays an `NYTPhotosViewController`, and houses the left and right abr button items, a title, and a caption view. | ||
* A view that overlays an `NYTPhotosViewController`, and houses the left and right bar button items, a title, and a caption view. | ||
*/ | ||
@interface NYTPhotosOverlayView : UIView | ||
|
||
|
@@ -21,36 +23,38 @@ | |
/** | ||
* The title of the overlay. Centered between the left and right bar button items. | ||
*/ | ||
@property (nonatomic) NSString *title; | ||
@property (nonatomic, copy, nullable) NSString *title; | ||
|
||
/** | ||
* The attributes of the overlay's title. | ||
*/ | ||
@property (nonatomic) NSDictionary *titleTextAttributes; | ||
@property(nonatomic, copy, nullable) NSDictionary <NSString *, id> *titleTextAttributes; | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
cdzombak
Author
Contributor
|
||
|
||
/** | ||
* The bar button item appearing at the top left of the overlay. | ||
*/ | ||
@property (nonatomic) UIBarButtonItem *leftBarButtonItem; | ||
@property (nonatomic, nullable) UIBarButtonItem *leftBarButtonItem; | ||
|
||
/** | ||
* The bar button items appearing at the top left of the overlay. | ||
*/ | ||
@property (nonatomic, copy) NSArray *leftBarButtonItems; | ||
@property (nonatomic, copy, nullable) NSArray <UIBarButtonItem *> *leftBarButtonItems; | ||
|
||
/** | ||
* The bar button item appearing at the top right of the overlay. | ||
*/ | ||
@property (nonatomic) UIBarButtonItem *rightBarButtonItem; | ||
@property (nonatomic, nullable) UIBarButtonItem *rightBarButtonItem; | ||
|
||
/** | ||
* The bar button items appearing at the top right of the overlay. | ||
*/ | ||
@property (nonatomic, copy) NSArray *rightBarButtonItems; | ||
@property (nonatomic, copy, nullable) NSArray <UIBarButtonItem *> *rightBarButtonItems; | ||
|
||
/** | ||
* A view representing the caption for the photo, which will be set to full width and locked to the bottom. Can be any `UIView` object, but is expected to respond to `intrinsicContentSize` appropriately to calculate height. | ||
*/ | ||
@property (nonatomic) UIView *captionView; | ||
@property (nonatomic, nullable) UIView *captionView; | ||
|
||
@end | ||
|
||
NS_ASSUME_NONNULL_END |
I am getting build errors now after pod install because of this change. I use swift on xcode 6.4
![screen shot 2015-10-23 at 9 33 24 am](https://cloud.githubusercontent.com/assets/6019211/10699093/4258140a-7969-11e5-9f99-dd440e8b2412.png)