Impl win permissions

[coddie83]

VPN-2214:file permissions on windows implementation

---

This change is 

[pronebird]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

---

nym-vpn-core/crates/nym-vpn-account-controller/src/storage/credentials/pending_credential_requests/mod.rs line 289 at r1 (raw file):

    // Set file permissions
    unsafe {
        if SetFileSecurityA(

Maybe we should use wide char version SetFileSecurityW and not ANSI

[pronebird]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @coddie83)

---

nym-vpn-core/crates/nym-vpn-account-controller/src/storage/credentials/pending_credential_requests/mod.rs line 227 at r1 (raw file):

    // FIXME: "SYSTEM" need to be changed to the required account(here and below)
    unsafe {
        LookupAccountNameA(

Let's use widechar version LookupAccountNameW

[pronebird]

Reviewable status: 0 of 2 files reviewed, 4 unresolved discussions (waiting on @coddie83)

---

nym-vpn-core/crates/nym-vpn-account-controller/src/storage/credentials/pending_credential_requests/mod.rs line 210 at r1 (raw file):

    let file_path = path.as_ref();
    let c_file_path = CString::new(file_path.to_str().unwrap()).map_err(|_| std::io::Error::from(std::io::ErrorKind::InvalidInput))?;

Maybe we can leverage widestring crate to do this heavy lifting for us.

---

nym-vpn-core/crates/nym-vpn-account-controller/src/storage/credentials/pending_credential_requests/mod.rs line 298 at r1 (raw file):

    }

    tracing::info!("Successfully set file permissions for {:?}", file_path);

You can use normal formatting with {} instead of debug formatting {:?} by calling it viafile_path.display()

[pronebird]

Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @coddie83)

---

nym-vpn-core/crates/nym-vpn-account-controller/Cargo.toml line 44 at r2 (raw file):

uuid.workspace = true
zeroize.workspace = true
windows = "0.59.0"

You don't need windows here as you solely use windows-sys

[pronebird]

Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @coddie83)

---

nym-vpn-core/crates/nym-vpn-account-controller/Cargo.toml line 46 at r2 (raw file):

windows = "0.59.0"
windows-sys = { version = "0.59.0", features = ["Win32_System_Threading", "Win32_System_SystemServices"] }
widestring = "1.0"

We keep all dependency versions in the workspace to make it easier to update them. widestring is a part of workspace so you can simply replace the version with workspace = true. Same goes for windows-sys, i.e:

widestring.workspace = true
windows-sys = { workspace = true, features = ["Win32_System_Threading", "Win32_System_SystemServices"] }

[pronebird]

Reviewed 1 of 2 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @coddie83)

[pronebird]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @coddie83)

[pronebird]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @coddie83)

---

nym-vpn-core/crates/nym-vpn-account-controller/Cargo.toml line 45 at r4 (raw file):

uuid.workspace = true
zeroize.workspace = true
windows-sys = { version = "0.59.0", features = ["Win32_System_Threading", "Win32_System_SystemServices"] }

windows-sys should use the version from workspace. Please change version = ... with workspace = true

[pronebird]

Reviewed 2 of 2 files at r4.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @coddie83)

[pronebird]

Reviewed 3 of 3 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @coddie83)

[pronebird]

Looks good. Windows CI has some minor issue.

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @coddie83)

[pronebird]

Reviewed 3 of 7 files at r6.
Reviewable status: 3 of 7 files reviewed, 2 unresolved discussions (waiting on @rokas-ambrazevicius)

---

nym-vpn-core/crates/nym-vpn-account-controller/Cargo.toml line 47 at r6 (raw file):

windows-sys = { workspace = true, features = ["Win32_System_Threading", "Win32_System_SystemServices"] }
widestring.workspace = true
winapi = { version = "0.3" }

Can we please use it from workspace too? All versions we have are defined in workspace Cargo.toml in the root.

---

nym-vpn-core/crates/nym-vpn-store/Cargo.toml line 26 at r6 (raw file):

windows-sys = { workspace = true, features = ["Win32_System_Threading", "Win32_System_SystemServices"] }
widestring.workspace = true
winapi = { version = "0.3" }

Please use version from workspace. It was moved there recently I think.

[pronebird]

Reviewed 4 of 7 files at r6.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @coddie83 and @rokas-ambrazevicius)