Standardize capitalization to am/pm, for message-list #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @cllns — this looks great, thanks for the fix! How do you feel about am/pm vs AM/PM? I looked at a couple other Mac apps for comparison (Mail.app and Evernote), and they seem to capitalize them everywhere. Maybe we should standardize them in the other direction? |
|
I think Maybe a designer at @nylas can chime in? |
|
Hey @cllns — we've decided to standardize on AM / PM (capitalized). Want to update this pull request real quick and we'll land it? Thanks! |
cllns
force-pushed
the
standardize-am-and-pm-capitalization
branch
from
b8ed9d3 to
f14087a
Compare
|
All set @bengotow! |
|
Thanks—welcome to the project! 🎉 |
bengotow
added a commit
that referenced
this pull request
Jan 20, 2016
Standardize capitalization to am/pm, for message-list
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time format for closed vs. expanded in the message-list is not consistent.
Closed:
Expanded:
A number of other things change, but if the time format is the same, it'll appear as though the only thing changing with the time is adding the date before it.
This patch fixes that.
I have no opinion on lowercase vs. uppercase. Switching it to lowercase was just an easier change.