Travis build script rework to allow completion under Pull Requests #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d process Found the order at https://docs.travis-ci.com/user/customizing-the-build/. In nylas/nylas-mail@989f38c the entire build script was merged from Evan Morikawa, which reordered the whole Travis build script. athis commit reorders the to have the Travis build environment config at the beginning of the script and the build process at the end and the Travis secure variables at the end of the script.
Travis provides a wonderful helper addon documented at https://docs.travis-ci.com/user/ssh-known-hosts/. The behavior changed moves the ssh-keyscan from the before_install stage to the addons stage.
|
Hey — thanks! cc @emorikawa |
|
@mbilker this looks great. Thanks for re-ordering to be more sensible and making it work on non-mainline branches. I just pushed after a rebase. |
|
Shoot. |
|
Weird thing is. https://github.com/travis-ci/travis-build/blob/master/lib/travis/build/addons/ssh_known_hosts.rb#L42-L47 says it only sets it to RSA and DSA on OS X. |
This was referenced Sep 2, 2021
This was referenced Feb 21, 2022
This was referenced Jun 30, 2022
This was referenced Dec 5, 2022
This was referenced May 22, 2024
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stems from recent failures I encountered at my forked repository and with the PR's I sent here.
In 989f38c the entire build script was merged from Evan Morikawa's branch for integrating AppVeyor, which reordered the whole Travis build script. This PR reorders the to have the Travis build environment config at the beginning of the script and the build process at the end and the Travis secure variables at the end of the script.
I also added added some conditions to run the decryption commands only on the main repository using
TRAVIS_PULL_REQUESTfrom Testing Pull Requests.