Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select multiple messages using ctrl / cmd key #388

Closed
g105b opened this issue Nov 10, 2015 · 8 comments
Closed

Select multiple messages using ctrl / cmd key #388

g105b opened this issue Nov 10, 2015 · 8 comments

Comments

@g105b
Copy link
Contributor

g105b commented Nov 10, 2015

Shift key works as expected in OS; click one mail in the list, shift-click another, and all mails in between are also selected.

Control/Command key should toggle selection of individual messages per click.

@bengotow
Copy link
Contributor

This issue appears to be platform-specific. On the Mac, cmd-clicking threads selects them individually. It seems we forgot to make this work on Windows / Linux. I'm not sure what the desired behavior is on Windows—in Windows Explorer, it looks like you have to ctrl-option-click to extend your selection. @g105b do you have any thoughts what the correct behavior should be?

@g105b
Copy link
Contributor Author

g105b commented Nov 13, 2015

My platform is Ubuntu Linux, I haven't tested on Windows.

The expected behaviour is to toggle the selected status of each clicked element while Ctrl is held, with no context to other selected elements.

@nomadturk
Copy link

Can't use ctrl key on Windows either. Shift key works but when I need to add another mail from X rows below to the selection, it doesn't work.

@haidaraM
Copy link

Same for me on Ubuntu. I can't use ctrl key to select multiple threads. Shift key works perfectly

@jwoodard80
Copy link

I would like to also confirm this issue.... Ctrl behavior does not work as expected, shift key works as expected.

Linux Mint 17.3 64bit Cinnamon

@bengotow
Copy link
Contributor

I'm tagging this as a good starter issue. Technically, we already support the behavior being described here. For some reason, the logic in this function is not working as you'd expect on Linux: https://github.com/nylas/N1/blob/unified-inbox/src/components/multiselect-list.cjsx#L140.

It looks like event.metaKey might not be the correct think to check for on Linux?

@g105b
Copy link
Contributor Author

g105b commented Jan 27, 2016

I can confirm that in Linux, multiple emails can be selected using the super key, instead of the ctrl key, as expected.

Might have a look at fixing this one myself later.

@g105b
Copy link
Contributor Author

g105b commented Jan 27, 2016

The Event object has a ctrlKey property, I think this should be standard on all platforms but in case I put it after the or operator as to not affect existing behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants