-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pressing the ESC key will now EXIT "FullScreen mode" with RM MV. #7324
Comments
Could you please provide a sample? It works for me. |
Hi Roger, I just made a quick RM MV sample project with your latest (0.43.6) NW: In order to reproduce the problem, after you launch the “game sample”, press the F4 key in order to go fullscreen, then push the ESC key like you want to call the in-game menu, and it will make you leave the fullscreen (like if you’d push F4 again) instead of calling the in-game menu. I hope you’ll be able to see the same behavior, I tried on 2 other computers and I could reproduce it, tell me if you wan’t me to upload the same sample with 0.41.3 instead (or you can simply replace the data in the folder) because that one was the last time everything was fine but it’s also because I skipped some updates in between, now that I see you keep a list of previous versions, I will try each one following 0.41.3 to see when it began to change. Maybe it will help you. |
Alright, after trying every version since my “last working one” I can say that the problem begins with version (x64) 0.42.4, and it's also when the game’s window began to be at the top-left instead of centered. |
The sample you provided is based on 0.43.3, not 0.43.6. When I tried to use 0.43.6 to launch your game, it doesn't enter fullscreen mode. |
Hi! It doesn’t.. ENTER? Did you mean to write “EXIT”, because it would be worrisome if we can’t even enter fullscreen on some configuration. (I never had that problem though.) Don’t forget that in vanilla RM MV the games don’t go fullscreen automatically and you have to push F4 first, I tried again with 0.43.6 and it’s always the same behavior (same as 0.43.3 anyway), you launch the game, you push F4 to go fullscreen, then start (to go on the map with all the cats) and when trying to bring the in-game menu pushing the ESC key, the game exits fullscreen instead of calling the menu, of course then if you push ESC again (windowed) the menu will work. I made a new sample with a plugin to automatically go fullscreen (and skip the menu) so there’s no misunderstanding (and made sure it’s the very last stable NW available on your website), here it is: http://koruldia.com/nw_mvtest.rar It’s the same kind of sample but with a plugin to be fullscreen automatically (so you don’t have to bother with F4) now push ESC to bring the menu you’ll see it will go back to windowed, then if you push ESC again you’ll get the intended behavior: calling the menu. Alternatively while fullscreen you can push the X key and you’ll see the normal behavior (calling the menu and staying in fullscreen) since X is an alternative key to ESC, if you have a NUM PAD on your keyboard, the ZERO key is also an alternative to ESC, and I usually use that key when playtesting, this is why I didn’t notice the problem straight away. If you need me to make a video of myself having the problem I can also do it quickly (filming my screen with my phone), I also was able to reproduce the issue on 3 different computers. As I said the change of behavior is here since 0.42.4 and I just didn’t notice until recent versions. |
Yes, it’s probably the case. Maybe some kind of conflict between RMMV (Pixi JS) and Node or Chromium. Out of curiosity, would it be possible to have an exclusive full-screen (not only the borderless window thing) one day if it’s technically possible? It often helps global performances. Well, tell me if there’s anything I can do to manually correct that “ESC key conflict”. Now that I think about it, would be amazing to have control on the behavior of the “NW window/frame” like that, giving us the option to fine-tune with our specific needs. Just a suggestion to improve your already great software. |
Another user reported with a sample so I can reproduce it now: https://groups.google.com/d/msg/nwjs-general/A3znJx9c0OE/IoPmREdMEwAJ Will fix it soon. Thanks. |
This is fixed in git and will be available in the next nightly build. |
Great news! Take care and good luck with future updates Roger. Cheers! |
The nightly build for this issue is available at https://dl.nwjs.io/live-build/nw44/20200128-162000/54f5ff5c2 |
Perfect, I tried and it's working just like before. Thank you! |
NWJS Version : 0.43.6
Operating System : Windows 10 (64bit)
Expected/Actual behavior
I noticed a new behavior in the latest NWJS update, my project was running with 0.43.3 so far (without any problem) but after updating to the latest version (0.43.6) now I notice that pressing the ESC key exits FULLSCREEN mode. It’s a pretty big problem since the ESC key is used to call the in-game menu in the engine I’m using for my project (RPG MAKER MV) and if someone wants to play with a keyboard it can be problematic.
How to reproduce
In order to go in FULLSCREEN with RM MV in the first place you'll need to press F4 since the game will be windowed by default. (Some JS plugins can add a FULLSCREEN option in the game-menu or turn it ON by default but let's assume a vanilla RM MV.)
Now normally the only way to go back to a windowed mode would be to press F4 again (or using the options provided by a plugin) but with the new update unfortunately pushing the ESC key will bring you to the windowed mode and call the in-game menu at the same time.
Thank you in advance and good luck with NW, it's an amazing software.
The text was updated successfully, but these errors were encountered: