Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webview.showDevtools(show, container) does not work on v0.35.2 #6903

Closed
hhhoney opened this issue Dec 18, 2018 · 2 comments
Closed

webview.showDevtools(show, container) does not work on v0.35.2 #6903

hhhoney opened this issue Dec 18, 2018 · 2 comments

Comments

@hhhoney
Copy link

hhhoney commented Dec 18, 2018 •
edited
Loading

on v0.35.2 (SDK, macOS Mojave, node 11.4.0), webview.showDevtools(show) works, but webview.showDevtools(show, container) throws an error:

Uncaught TypeError: container.getGuestId is not a function
    at ChromeWebViewImpl.WebViewImpl.showDevTools (extensions::webView:229)
    at HTMLElement.showDevTools (extensions::guestViewContainerElement:141)

Reproduce Demo:
webview.zip

Debug screenshot [extensions::webview]:
getguestid
@hhhoney hhhoney changed the title 【bu g webview.showDevtools(show, container) does not work on v0.35.2 Dec 18, 2018
rogerwang added a commit that referenced this issue Dec 18, 2018
@rogerwang
src: Fix #6903: webview.showDevtools regression
866a8bb 
nwjs/chromium.src@48835d6
@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

@rogerwang
Copy link
Member

https://dl.nwjs.io/live-build/nw35/12-19-2018/7c0df2185/v0.35.3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rogerwang @hhhoney