Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window menubar can be unreadable on certain OS themes #5007

Closed
jonwwilkes opened this issue Jun 20, 2016 · 3 comments
Closed

window menubar can be unreadable on certain OS themes #5007

jonwwilkes opened this issue Jun 20, 2016 · 3 comments
Assignees

Comments

@jonwwilkes
Copy link

Version 0.15.3 on Ubuntu 14.04

A user of my application has reported an unreadable window menubar when using the "Dark Theme" on Ubuntu.

It looks like nw.js window menubar is inheriting the background color from the theme, but not the text color?

dark-theme

@ghostoy
Copy link
Member

ghostoy commented Jun 21, 2016

@jonwwilkes The text shows on 3 themes installed by default on Ubuntu 14.04. I don't see "Dark Theme" in the settings. Where can I get and install the "Dark Theme" so that I can test with it?

@jonwwilkes
Copy link
Author

@ghostoy Oops, I neglected to get the name of the theme from the user. I had wrongly assumed it was a built-in theme. I'm waiting on a response from the user to get the exact name of the theme (and where he/she got it...)

@jonwwilkes
Copy link
Author

@ghostoy I've been told the theme is numix

ghostoy pushed a commit to ghostoy/nw.js that referenced this issue Jun 23, 2016
Foreground colors used by menubar buttons should be consistent
with themes provided by the system. We use same foreground color
as menu items.

fixed nwjs#5007
rogerwang pushed a commit that referenced this issue Jun 25, 2016
Foreground colors used by menubar buttons should be consistent
with themes provided by the system. We use same foreground color
as menu items.

fixed #5007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants