Issus #1836: add view.debounce_delay, avoid some unnecessary reloads #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… explorer reloads
alex-courtis
requested changes
Dec 31, 2022
There was a problem hiding this comment.
Thanks for tackling this one. Tested
- buffer switching - filter disabled
- filter enabled
- 1s debounce
- bw :
Error detected while processing BufUnload Autocommands for "*":
Error executing lua callback: ...-dev/site/pack/packer/start/D0ot/lua/nvim-tree/utils.lua:383: bad argument #1 to 'start' (number expected, got nil)
stack traceback:
[C]: in function 'start'
...-dev/site/pack/packer/start/D0ot/lua/nvim-tree/utils.lua:383: in function 'debounce'
/tmp/nvt-dev/site/pack/packer/start/D0ot/lua/nvim-tree.lua:385: in function </tmp/nvt-dev/site/pack/packer/start/D0ot/lua/nvim-tree.lua:379>
Suggestion:
Remove debounce from unload. It's a rare use case that doesn't warrant debounce.
| @@ -368,7 +368,9 @@ local function setup_autocommands(opts) | |||
| (filters.config.filter_no_buffer or renderer.config.highlight_opened_files ~= "none") | |||
| and vim.bo[data.buf].buftype == "" | |||
| then | |||
| reloaders.reload_explorer() | |||
| utils.debounce("BufReadPost:filter_buffer", view.debounce_delay, function() | |||
There was a problem hiding this comment.
One context should work well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add DEFAULT_OPTS.view.debounce_delay and view.debounce_delay.
accidentally close the old PR #1830, I just created a new one...