Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: offset_encoding is required now in make_position_params #3368

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

rockyzhang24
Copy link
Contributor

@rockyzhang24 rockyzhang24 commented Nov 24, 2024

Adapt to the upstream change neovim/neovim@629483e to get rid of the warning message "warning: offset_encoding is required, using the offset_encoding from the first client".

Since the commit neovim/neovim@2dcbfe7, params in buf_request can accept a function that takes the client as a parameter. So instead of sending the same params to all servers, the params with correct offset_encoding will send to each single server.

@rockyzhang24 rockyzhang24 force-pushed the fix-encoding branch 5 times, most recently from ecd4fee to eee3a75 Compare November 29, 2024 07:19
@rockyzhang24
Copy link
Contributor Author

rockyzhang24 commented Nov 29, 2024

I just realized that the has function for checking version numbers returns 0 or 1 instead of a boolean. I’ve fixed it, and everything should be fine now. It’s ready to be merged.

@Conni2461
Copy link
Member

thanks for the contribution :) i left a couple of nits

@Conni2461 Conni2461 merged commit 2eca9ba into nvim-telescope:master Nov 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants