chore(ci): tweak docgen event #3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestrew
force-pushed
the
docgen-target
branch
from
7e4c9dc to
2073a24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
pull_request->pull_request_targetThis should allow forks of non-members to generate docs with the docgen workflow.
Unlike the
pull_requestevent which only grants read access toGITHUB_TOKEN,pull_request_targetgrants read/write. This should still be safe as unlikepull_request,pull_request_targetruns in the context of the base of the pull request rather than the pull request itself. So someone can't update docgen.yml to something malicious in the PR and have that docgen workflow run.