-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add spoiler, superscript and subscript attached modifiers #20
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the changes!
Could you please also modify the according tests for the attached modifiers? CI seems to be failing :p
Sorry, didn't notice the tests, I made the changes at 1 AM 😅 It will be done |
I looked into it and found the issue. The failing test is testing this snippet
Due to an attached modifier being able to span multiple paragraph segments the exclamation marks cause it to parse as a spoiler. I'm going to escape the exclamation marks and see if it fixes the test |
Seems like it's not only that, it somehow messes up parsing of attached modifiers altogether |
So the issue here is with the attached modifier parsing that becomes very apparent when these common symbols are added as attached modifiers. On main, I can replicate the issue that we see on this branch with an example like: I don't think this is at all easy to solve, will probably require a re-write of a lot of the detached modifier parsing code. |
issue is somewhat related to #9 |
Yeah I stumbled upon this as well but somewhat dropped it due to real life things, should have brought it up earlier, sorry |
The change in 582 has been made by my autoformatter doing format on save. I didn't notice it until I made this pr