Fix for issue #1121 #1334
Closed
Fix for issue #1121 #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the problem described in #1121. Maybe with the latest greatest nvim this problem is also bypassed (see 086891d). But the fix is still relevant for older nvim versions.
The problem seems to be that lua
line:submethod is not Unicode-aware and does not work properly with strings that contain Unicode characters. That is definitely the case when concealer required more than one substitution (one for heading, one for todo marks). First substitution (heading) would work fine, but the second one (todo mark) would become off.