-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move to luarocks #1316
Merged
feat: move to luarocks #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything should now be working! The implementation can be tested with the following snippet: {
"vhyrro/luarocks.nvim",
priority = 1000,
config = true,
},
{
"nvim-neorg/neorg",
branch = "luarocks",
dependencies = { "luarocks.nvim" },
config = function()
require("neorg").setup({
load = {
["core.defaults"] = {},
}
})
end
} If you get any errors in the meantime then please do let me know! |
We are nearing the release of Neorg 8.0.0! Just a few errands left to run :) |
…elf (prevent conflicts)
Moment of truth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be a massive paradigm shift in how we do things - get ready!
Neorg + Luarocks = 💜
This PR shifts Neorg from being a git-first plugin to being a luarocks-first plugin. Luarocks is the standard Lua package manager.
This is what it means for everyone:
Luarocks genuinely makes plugin management within Neovim much, much easier.
Here are the things that will be changing for users post-
8.0.0
:While it's much easier to install something from luarocks when the plugin manager itself supports luarocks, lazy users can still install Neorg just fine with some tweaks.
build.lua
which will attempt to interface with the luarocks plugin to install Neorg as a rock - thanks to this the user won't have to do any installation themselves. This should make the experience streamlined, generally hassle-free and should hopefully encourage more people to start adopting luarocks in their workflows :)After this is released I'll also spend a bunch of time going through the Neorg codebase and cleaning it up (including fleshing out existing features and improving them where possible). Now that we'll have access to libraries whose developers spent ages perfecting, we won't have to worry about odd bugs popping up in our code. More developer time will be aimed at feature development instead of writing code that has already been written for us 😆