Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(highlights)!: updated default groups to match names in treesitter #1286

Merged
merged 2 commits into from
Feb 15, 2024
Merged

fix(highlights)!: updated default groups to match names in treesitter #1286

merged 2 commits into from
Feb 15, 2024

Conversation

ALVAROPING1
Copy link
Contributor

Matches the new names in nvim-treesitter/nvim-treesitter@1ae9b0e

This is a breaking change for users whose colorscheme hasn't been updated yet to follow this change

Matches the new names in nvim-treesitter/nvim-treesitter@1ae9b0e

This is a breaking change for users whose colorscheme hasn't been updated yet to follow this change
@ALVAROPING1
Copy link
Contributor Author

ALVAROPING1 commented Jan 23, 2024

Is there any reason for these to not be linked to @markup.underline and @markup.strikethrough respectively?

underline = {
[""] = "cterm=underline gui=underline",
delimiter = "+NonText",
},
strikethrough = {
[""] = "cterm=strikethrough gui=strikethrough",
delimiter = "+NonText",
},

Should we link this to @markup.list?

@vhyrro
Copy link
Member

vhyrro commented Feb 15, 2024

Enough time should have passed for people to update now properly.

@ALVAROPING1 with the new hl groups we will want to remap to markup.strikethrough and markup.underline yep! The @markup.list change also sounds good to me 👍

@ALVAROPING1
Copy link
Contributor Author

should be good to merge now then, I have updated the remaining groups

@vhyrro
Copy link
Member

vhyrro commented Feb 15, 2024

Fantastic, thank you! :)

@vhyrro vhyrro merged commit e7f524c into nvim-neorg:main Feb 15, 2024
1 of 2 checks passed
@ALVAROPING1 ALVAROPING1 deleted the fix-highlights branch February 15, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants