Fix in-place Python installs #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not based upon if the build type being performed is a debug build
dagardner-nv
added
bug
|
LGTM. but the commit is changing the purpose of the flags? |
AnuradhaKaruppiah
approved these changes
Oct 4, 2024
In my opinion While My guess is that this went un-noticed for a while since many people wanting an in-place build are also performing a debug build. |
mdemoret-nv
approved these changes
Oct 16, 2024
|
/merge |
rapids-bot bot
pushed a commit
to nv-morpheus/Morpheus
that referenced
this pull request
Oct 16, 2024
* Picks up fix from nv-morpheus/utilities#81 Closes #1923 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: #1952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-eflag topip isntallbased on theIS_INPLACEargument rather than the value of theCMAKE_BUILD_TYPEThis is needed to resolve nv-morpheus/Morpheus#1923
Checklist