Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid private cudf DeviceScalar in favor of using pylibcudf & pyarrow #2090

Merged
12 changes: 6 additions & 6 deletions python/morpheus/morpheus/_lib/cudf_helpers.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ cimport pylibcudf.libcudf.copying as cpp_copying
from pylibcudf.libcudf.column.column_view cimport column_view
from libcpp.memory cimport make_unique, unique_ptr
from pylibcudf.libcudf.scalar.scalar cimport scalar
from pylibcudf cimport Table as plc_Table
from cudf._lib.scalar cimport DeviceScalar
from pylibcudf cimport Table as plc_Table, Scalar as plc_Scalar
import pylibcudf as plc

# imports needed for from_column_view_with_fix
import rmm
Expand Down Expand Up @@ -72,9 +72,9 @@ cdef get_element(column_view col_view, size_type index):
cpp_copying.get_element(col_view, index)
)

return DeviceScalar.from_unique_ptr(
move(c_output), dtype=dtype_from_column_view(col_view)
)
plc_scalar = plc_Scalar.from_libcudf(move(c_output))
return plc.interop.to_arrow(plc_scalar).as_py()


cdef Column from_column_view_with_fix(column_view cv, object owner):
"""
Expand Down Expand Up @@ -119,7 +119,7 @@ cdef Column from_column_view_with_fix(column_view cv, object owner):
base_nbytes = 0
else:
chars_size = get_element(
offset_child_column, offset_child_column.size()-1).value
offset_child_column, offset_child_column.size()-1)
base_nbytes = chars_size

if data_ptr:
Expand Down
2 changes: 2 additions & 0 deletions python/morpheus/morpheus/_lib/cudf_helpers/__init__.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ from cudf.core.dtypes import StructDtype
import _cython_3_0_11
import cudf
import itertools
import pylibcudf
import rmm

__all__ = [
Expand All @@ -19,6 +20,7 @@ __all__ = [
"bitmask_allocation_size_bytes",
"cudf",
"itertools",
"plc",
"rmm"
]

Expand Down
Loading