Move isort settings into pyproject.toml #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fixup to commit 4e3edb9 that refactored the setup files Signed-off-by: Anuradha Karuppiah <[email protected]>
|
/ok to test |
AnuradhaKaruppiah
approved these changes
Aug 19, 2024
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
Update `isort` settings file path in `fix_all.sh` to `${PROJ_TOML}` so that this script finds the config path correctly.
This is a follow-up PR of #1854.
## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.
Authors:
- Yuchen Zhang (https://github.com/yczhang-nv)
Approvers:
- David Gardner (https://github.com/dagardner-nv)
- Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
URL: #1855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
testswas listed insrc_pathsbut this was expected to be relative topython/morpheusBy Submitting this PR I confirm: