Improve the logging tests and add support for resetting the logger #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdemoret-nv
added
non-breaking
dagardner-nv
approved these changes
May 30, 2024
Co-authored-by: David Gardner <[email protected]>
Co-authored-by: David Gardner <[email protected]>
…e benchmarks themselves all call configure_logging
…ng test collection
…dd_fix-logging-tests
|
/merge |
dagardner-nv
pushed a commit
to dagardner-nv/Morpheus
that referenced
this pull request
Jun 4, 2024
…v-morpheus#1716) - Allows the logger to be "reset" which is necessary to avoid duplicate logging handlers if `configure_logging` is called multiple times - Updates all of the logging tests to parameterize the log level and better check if the handlers are actually being called. - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Michael Demoret (https://github.com/mdemoret-nv) - David Gardner (https://github.com/dagardner-nv) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: nv-morpheus#1716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
configure_loggingis called multiple timesBy Submitting this PR I confirm: