Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Test removal of pybind11 patch #961

Closed
2 tasks done
dagardner-nv opened this issue Jun 1, 2023 · 0 comments · Fixed by #1001
Closed
2 tasks done

[FEA]: Test removal of pybind11 patch #961

dagardner-nv opened this issue Jun 1, 2023 · 0 comments · Fixed by #1001
Assignees
@dagardner-nv
Labels
feature request New feature or request

Comments

@dagardner-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Change

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem this feature solves

Since we no longer run python code inside of fibers, we likely no longer require our pybind11 patch.

Describe your ideal solution

Remove the patch

Describe any alternatives you have considered

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@dagardner-nv dagardner-nv added the feature request New feature or request label Jun 1, 2023
@dagardner-nv dagardner-nv self-assigned this Jun 1, 2023
@dagardner-nv dagardner-nv moved this from Todo to In Progress in Morpheus Boards Jun 13, 2023
@dagardner-nv dagardner-nv mentioned this issue Jun 13, 2023
Merged
3 tasks
rapids-bot bot pushed a commit to nv-morpheus/utilities that referenced this issue Jun 21, 2023
@dagardner-nv
Remove patch from pybind11 (#43)
a5b9689 
* Removes pybind11 patch
* All MRC & Morpheus tests are passing with this change

Part of nv-morpheus/Morpheus#961

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #43
@dagardner-nv dagardner-nv mentioned this issue Jun 21, 2023
Merged
3 tasks
rapids-bot bot pushed a commit to nv-morpheus/MRC that referenced this issue Jun 26, 2023
@dagardner-nv
Remove patch from pybind11 (#335)
7efa871 
* Adopt updated utilities repo to pickup changes from nv-morpheus/utilities#43
* Removes pybind11 patch

Part of nv-morpheus/Morpheus#961

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #335
This was referenced Jun 27, 2023
Merged
Closed
rapids-bot bot pushed a commit that referenced this issue Jun 29, 2023
@dagardner-nv
Remove patch from pybind11 (#1001)
4e3b669 
* Adopt updated utilities repo to pickup changes from nv-morpheus/utilities#43
* Removes pybind11 patch

fixes #961

Authors:
  - David Gardner (https://github.com/dagardner-nv)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1001
@github-project-automation github-project-automation bot moved this from In Progress to Done in Morpheus Boards Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
feature request New feature or request
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove patch from pybind11 dagardner-nv/Morpheus
1 participant
@dagardner-nv