Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Version string in CMakeLists.txt C++ examples being missed by ci/release/update-version.sh script #1779

Closed
2 tasks done
dagardner-nv opened this issue Jun 28, 2024 · 0 comments · Fixed by #1801
Closed
2 tasks done

[BUG]: Version string in CMakeLists.txt C++ examples being missed by ci/release/update-version.sh script #1779

dagardner-nv opened this issue Jun 28, 2024 · 0 comments · Fixed by #1801
Assignees
@dagardner-nv
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

24.06

Which installation method(s) does this occur on?

Source

Describe the bug.

I just noticed that the version in examples/developer_guide/3_simple_cpp_stage/CMakeLists.txt and examples/developer_guide/4_rabbitmq_cpp_stage/CMakeLists.txt were still set to 24.03

Minimum reproducible example

No response

Relevant log output

Click here to see error details
[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details
[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Jun 28, 2024
@dagardner-nv dagardner-nv mentioned this issue Jun 28, 2024
Merged
rapids-bot bot pushed a commit that referenced this issue Jun 28, 2024
@dagardner-nv
Add cuda and cudf to link targets for C++ examples (#1777)
caf6c07 
* Also update out of date version strings (refer: #1779)

Closes #1772

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1777
@dagardner-nv dagardner-nv mentioned this issue Jul 5, 2024
Merged
@morpheus-bot-test morpheus-bot-test bot moved this from Todo to Review - Ready for Review in Morpheus Boards Jul 5, 2024
@dagardner-nv dagardner-nv self-assigned this Jul 5, 2024
@rapids-bot rapids-bot bot closed this as completed in #1801 Jul 5, 2024
@rapids-bot rapids-bot bot closed this as completed in a742ade Jul 5, 2024
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ci/release/update-version.sh to include missed files dagardner-nv/Morpheus
1 participant
@dagardner-nv