-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: vdb_upload example pipeline error on inserting large strings #1650
Comments
The issue is that Milvus has a max string length of 65535 bytes. Characters such as |
This appears to be in part a bug on the milvus side as well. If I create a string containing multi-byte characters that is two characters longer than the max of 65535 chars, I receive this exception reflecting the char-length of 65537:
If I then truncate the data and retry, then I receive a new exception this time reflecting the byte length or 196605:
|
* Adds new helper methods to `morpheus.io.utils`, `cudf_string_cols_exceed_max_bytes` and `truncate_string_cols_by_bytes` * When `truncate_long_strings=True` `MilvusVectorDBResourceService` will truncate all `VARCHAR` fields according to the schema's `max_length` * Add `truncate_long_strings=True` in config for `vdb_upload` pipeline * Set C++ mode to default for example LLM pipelines * Remove issues 1650 & 1651 from `known_issues.md` Closes #1650 Closes #1651 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1665
Version
24.03
Which installation method(s) does this occur on?
Source
Describe the bug.
Occurs intermittently, presumably based on the content fetched via the RSS feeds.
Minimum reproducible example
Relevant log output
Click here to see error details
Full env printout
Click here to see environment details
Other/Misc.
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: