Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: improve concept definitions #521

Conversation

willkill07
Copy link
Contributor

@willkill07 willkill07 commented Dec 3, 2024

Description

  • Clean up concept definitions
  • Fix ParallelTests/NodeMultiThread bug

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Dec 3, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@willkill07 willkill07 requested a review from a team as a code owner December 3, 2024 17:56
@willkill07 willkill07 added improvement Improvement to existing functionality non-breaking Non-breaking change labels Dec 3, 2024
@willkill07 willkill07 force-pushed the will-chore-improve-concept-definitions branch from b8203ed to 735455f Compare December 3, 2024 17:59
@willkill07 willkill07 force-pushed the will-chore-improve-concept-definitions branch from 1ac88b5 to 6704705 Compare December 3, 2024 18:07
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The less decltype's the better in my opinion

@willkill07
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 7961e5a into nv-morpheus:branch-25.02 Dec 3, 2024
17 checks passed
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.16%. Comparing base (10439b3) to head (3565138).
Report is 1 commits behind head on branch-25.02.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-25.02     #521      +/-   ##
================================================
- Coverage         74.18%   74.16%   -0.02%     
================================================
  Files               407      407              
  Lines             15051    15051              
  Branches           1191     1191              
================================================
- Hits              11165    11162       -3     
- Misses             3886     3889       +3     
Flag Coverage Δ
cpp 70.70% <ø> (-0.01%) ⬇️
py 44.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../mrc/include/mrc/coroutines/concepts/awaitable.hpp 0.00% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10439b3...3565138. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants