Avoid compiler warnings #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compiler macro, avoids a build warning: ``` /home/dagardner/work/conda/envs/mrc2/include/boost/fiber/buffered_channel.hpp:71:18: warning: argument 1 value '18446744073709551615' exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=] 71 | slots_ = new slot_type[capacity_]; ``` Remove unused macros
…r than a compiler macro, avoids a build warning:" This reverts commit 136d27d.
…ating arrays larger than PTRDIFF_MAX
dagardner-nv
added
improvement
mdemoret-nv
approved these changes
Nov 20, 2024
|
/merge |
rapids-bot bot
pushed a commit
to nv-morpheus/Morpheus
that referenced
this pull request
Nov 20, 2024
* Set CMake policy #`CMP0144` to `NEW` in C++ examples, avoids a deprecation warning * Set `-lto=auto` to avoid a warning about falling back to serialized compilation. Related to nv-morpheus/MRC#518 . Closes #1988 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #2054
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-25.02 #518 +/- ##
=============================================
Coverage 74.17% 74.18%
=============================================
Files 407 407
Lines 15049 15051 +2
Branches 1192 1192
=============================================
+ Hits 11163 11165 +2
Misses 3886 3886
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-lto=autoto avoid a warning about [falling back to serialized compilation (cpp/mrc/CMakeLists.txt)PTRDIFF_MAXtoboost::fibers::buffered_channelavoids a -Walloc-size-larger-than compiler warning (cpp/mrc/include/mrc/channel/buffered_channel.hpp).Everything else is an IWYU fix
Part of nv-morpheus/Morpheus#1988
Closes #516
Checklist