Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IWYU fixes #517

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

dagardner-nv
Copy link
Contributor

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Nov 1, 2024
@dagardner-nv dagardner-nv self-assigned this Nov 1, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner November 1, 2024 21:17
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit af67e11 into nv-morpheus:branch-24.10 Nov 1, 2024
17 of 18 checks passed
@dagardner-nv dagardner-nv deleted the david-2410-iwyu branch November 1, 2024 21:48
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.17%. Comparing base (fff44d6) to head (985f821).
Report is 1 commits behind head on branch-24.10.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-24.10     #517   +/-   ##
=============================================
  Coverage         74.17%   74.17%           
=============================================
  Files               407      407           
  Lines             15049    15049           
  Branches           1191     1191           
=============================================
  Hits              11163    11163           
  Misses             3886     3886           
Flag Coverage Δ
cpp 70.72% <ø> (ø)
py 44.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/mrc/_pymrc/src/segment.cpp 80.82% <ø> (ø)
python/mrc/core/coro.cpp 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff44d6...985f821. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants