Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding environment variable to allow skip NUMA node check #505

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

mdemoret-nv
Copy link
Contributor

@mdemoret-nv mdemoret-nv commented Oct 10, 2024

If the NUMA node check fails for a GPU, the entire pipeline cannot start. This allows setting MRC_SKIP_NUMA_CHECK=1 to bypass the assertion if the check fails.

Closes #504

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels Oct 10, 2024
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner October 10, 2024 02:31
Copy link

copy-pr-bot bot commented Oct 10, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mdemoret-nv
Copy link
Contributor Author

/ok to test

@dagardner-nv
Copy link
Contributor

/ok to test

@dagardner-nv
Copy link
Contributor

/ok to test

@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 43f200e into nv-morpheus:branch-24.10 Oct 10, 2024
17 checks passed
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.98%. Comparing base (cef7f0b) to head (49be45d).
Report is 1 commits behind head on branch-24.10.

Files with missing lines Patch % Lines
cpp/mrc/src/internal/system/partitions.cpp 25.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.10     #505      +/-   ##
================================================
+ Coverage         73.97%   73.98%   +0.01%     
================================================
  Files               403      403              
  Lines             14467    14471       +4     
  Branches           1136     1138       +2     
================================================
+ Hits              10702    10707       +5     
+ Misses             3765     3764       -1     
Flag Coverage Δ
cpp 70.54% <25.00%> (+0.02%) ⬆️
py 42.65% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cpp/mrc/src/internal/system/partitions.cpp 77.37% <25.00%> (-0.83%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef7f0b...49be45d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG]: MRC Hangs if no NUMA nodes are configured
3 participants