Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch 24.06 RAPIDS 24.06 #498

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Sep 9, 2024

Description

Depends on nv-morpheus/utilities#77

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@cwharris cwharris added non-breaking Non-breaking change feature request New feature or request labels Sep 9, 2024
@cwharris cwharris requested review from a team as code owners September 9, 2024 19:37
@cwharris cwharris marked this pull request as draft September 9, 2024 19:37
@cwharris cwharris marked this pull request as ready for review September 18, 2024 19:52
@mdemoret-nv mdemoret-nv merged commit 160419d into nv-morpheus:branch-24.06-rapids-24.06 Sep 18, 2024
11 of 13 checks passed
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.95%. Comparing base (cc89f5f) to head (d62a56e).
Report is 1 commits behind head on branch-24.06-rapids-24.06.

Files with missing lines Patch % Lines
python/mrc/_pymrc/src/logging.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                      @@
##           branch-24.06-rapids-24.06     #498      +/-   ##
=============================================================
- Coverage                      74.09%   73.95%   -0.15%     
=============================================================
  Files                            403      403              
  Lines                          14401    14430      +29     
  Branches                        1132     1132              
=============================================================
+ Hits                           10670    10671       +1     
- Misses                          3731     3759      +28     
Flag Coverage Δ
cpp 70.76% <0.00%> (-0.09%) ⬇️
py 41.81% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cpp/mrc/include/mrc/core/utils.hpp 45.16% <ø> (ø)
cpp/mrc/src/internal/utils/contains.hpp 100.00% <ø> (ø)
python/mrc/_pymrc/src/logging.cpp 68.75% <0.00%> (-2.22%) ⬇️

... and 33 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc89f5f...d62a56e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants