Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-24.03 into branch-24.06 #471

Merged

Conversation

dagardner-nv
Copy link
Contributor

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

dagardner-nv and others added 6 commits April 6, 2024 00:13
…s#464)

Adds maximum simultaneous tasks support to `TaskContainer` by only starting new tasks if the number of currently executing tasks is less than the maximum number of simultaneous tasks and starting new tasks as older tasks shut down. this eliminates the need for external semaphores or ticketing systems.

Authors:
  - Christopher Harris (https://github.com/cwharris)
  - David Gardner (https://github.com/dagardner-nv)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: nv-morpheus#464
@dagardner-nv dagardner-nv self-assigned this Apr 10, 2024
@dagardner-nv dagardner-nv requested review from a team as code owners April 10, 2024 23:37
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Merging #471 (2308e23) into branch-24.06 (0701b13) will increase coverage by 0.14%.
The diff coverage is 92.85%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.06     #471      +/-   ##
================================================
+ Coverage         73.84%   73.99%   +0.14%     
================================================
  Files               403      403              
  Lines             14390    14414      +24     
  Branches           1128     1133       +5     
================================================
+ Hits              10627    10665      +38     
+ Misses             3763     3749      -14     
Flag Coverage Δ
cpp 69.34% <92.85%> (-1.11%) ⬇️
py 41.81% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cpp/mrc/include/mrc/coroutines/test_scheduler.hpp 100.00% <ø> (+100.00%) ⬆️
cpp/mrc/src/public/coroutines/test_scheduler.cpp 61.76% <100.00%> (+61.76%) ⬆️
...thon/mrc/_pymrc/include/pymrc/asyncio_runnable.hpp 95.23% <100.00%> (+0.15%) ⬆️
cpp/mrc/src/public/coroutines/task_container.cpp 88.46% <91.17%> (+9.39%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0701b13...2308e23. Read the comment docs.

@dagardner-nv dagardner-nv merged commit 41afd96 into nv-morpheus:branch-24.06 Apr 11, 2024
17 of 18 checks passed
@dagardner-nv dagardner-nv deleted the branch-24.06-merge-24.03 branch April 11, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants