Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TestScheduler to support testing time-based coroutines without waiting for timeouts #453

Merged
merged 13 commits into from
Mar 25, 2024

Conversation

cwharris
Copy link
Contributor

Description

Adds a manually driven TestScheduler that can fast-forward through delayed coroutines.

Required for nv-morpheus/Morpheus#1548

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@cwharris cwharris added non-breaking Non-breaking change feature request New feature or request conda-build Enables running the conda-build step on a PR labels Mar 12, 2024
@cwharris cwharris requested a review from a team as a code owner March 12, 2024 18:14
@mdemoret-nv mdemoret-nv changed the title Add TestScheduler Add TestScheduler to support testing time-based coroutines without waiting for timeouts Mar 25, 2024
@mdemoret-nv
Copy link
Contributor

/merge

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Merging #453 (89c299c) into branch-24.03 (2dbd985) will decrease coverage by 0.16%.
Report is 2 commits behind head on branch-24.03.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.03     #453      +/-   ##
================================================
- Coverage         73.81%   73.65%   -0.16%     
================================================
  Files               398      400       +2     
  Lines             14228    14260      +32     
  Branches           1108     1111       +3     
================================================
+ Hits              10502    10503       +1     
- Misses             3726     3757      +31     
Flag Coverage Δ
cpp 70.16% <0.00%> (-0.18%) ⬇️
py 41.77% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cpp/mrc/include/mrc/coroutines/test_scheduler.hpp 0.00% <0.00%> (ø)
cpp/mrc/src/public/coroutines/test_scheduler.cpp 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dbd985...89c299c. Read the comment docs.

@rapids-bot rapids-bot bot merged commit bd7955e into nv-morpheus:branch-24.03 Mar 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda-build Enables running the conda-build step on a PR feature request New feature or request non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants