-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant copy of libmrc_pymrc.so #429
Remove redundant copy of libmrc_pymrc.so #429
Conversation
…s from being owned by root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make sure the conda build works correctly on this before mergine.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-24.03 #429 +/- ##
=============================================
Coverage 74.00% 74.00%
=============================================
Files 394 394
Lines 13955 13955
Branches 1053 1053
=============================================
Hits 10327 10327
Misses 3628 3628
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
/merge |
Description
libmrc_pymrc.so
from being installed into python's site-packages dir, as this lib is already present in the lib dir.root:root
, simply ensuring the env retains theconda
group permission wasn't sufficient ascmake
attempts to modify exiting dirs (https://gitlab.kitware.com/cmake/cmake/-/issues/10978), and runningchmod -R
after the fact is too slow.Closes #428
Checklist