Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant copy of libmrc_pymrc.so #429

Merged
merged 7 commits into from
Jan 5, 2024

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Dec 27, 2023

Description

  • Prevent libmrc_pymrc.so from being installed into python's site-packages dir, as this lib is already present in the lib dir.
  • Fixes permissions issue where the conda env was owned by root:root, simply ensuring the env retains the conda group permission wasn't sufficient as cmake attempts to modify exiting dirs (https://gitlab.kitware.com/cmake/cmake/-/issues/10978), and running chmod -R after the fact is too slow.

Closes #428

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner December 27, 2023 19:04
@dagardner-nv dagardner-nv marked this pull request as draft December 27, 2023 19:34
@dagardner-nv dagardner-nv self-assigned this Dec 27, 2023
@dagardner-nv dagardner-nv marked this pull request as ready for review December 27, 2023 19:41
@dagardner-nv dagardner-nv requested a review from a team as a code owner December 27, 2023 19:41
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Dec 27, 2023
@dagardner-nv dagardner-nv marked this pull request as draft December 27, 2023 22:33
@dagardner-nv dagardner-nv marked this pull request as ready for review December 27, 2023 23:50
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make sure the conda build works correctly on this before mergine.

@mdemoret-nv mdemoret-nv added the conda-build Enables running the conda-build step on a PR label Jan 4, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Merging #429 (c8e07f2) into branch-24.03 (368fe7a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-24.03     #429   +/-   ##
=============================================
  Coverage         74.00%   74.00%           
=============================================
  Files               394      394           
  Lines             13955    13955           
  Branches           1053     1053           
=============================================
  Hits              10327    10327           
  Misses             3628     3628           
Flag Coverage Δ
cpp 70.47% <ø> (ø)
py 42.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 368fe7a...c8e07f2. Read the comment docs.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 294e087 into nv-morpheus:branch-24.03 Jan 5, 2024
18 checks passed
@dagardner-nv dagardner-nv deleted the david-dup-pymrc branch January 5, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conda-build Enables running the conda-build step on a PR non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: libmrc_pymrc.so installed twice
2 participants