Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local CI scripts & rebase docker image #394

Merged
merged 28 commits into from
Sep 25, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Sep 20, 2023

Description

  • Docker image uses rapidsai/ci-conda as the base per rapidsai/ops#2806
  • Adds the ability to CI locally via ./ci/scripts/run_ci_local.sh build & ./ci/scripts/run_ci_local.sh test
  • Fix type-o in benchmark stage causing benchmarks to be executed twice & preventing results from being published.
  • Add .tmp and .clangd to .gitignore
  • Document need to set DOCKER_BUILDKIT=1 for docker builds.

fixes #393
fixes #397

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner September 20, 2023 16:14
@dagardner-nv dagardner-nv self-assigned this Sep 20, 2023
@dagardner-nv dagardner-nv added improvement Improvement to existing functionality non-breaking Non-breaking change DO NOT MERGE labels Sep 20, 2023
@dagardner-nv dagardner-nv changed the title Draft: Add local CI scripts & rebase docker image Add local CI scripts & rebase docker image Sep 21, 2023
README.md Show resolved Hide resolved
ci/scripts/github/common.sh Show resolved Hide resolved
ci/scripts/github/conda.sh Outdated Show resolved Hide resolved
ci/scripts/bootstrap_local_ci.sh Outdated Show resolved Hide resolved
ci/scripts/bootstrap_local_ci.sh Show resolved Hide resolved
ci/scripts/run_ci_local.sh Show resolved Hide resolved
@cwharris
Copy link
Contributor

Is there an issue associated with the run ci locally related work?

@dagardner-nv
Copy link
Contributor Author

Is there an issue associated with the run ci locally related work?

There is now #397

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #394 (f5aaf38) into branch-23.11 (40d20a3) will increase coverage by 0.00%.
Report is 1 commits behind head on branch-23.11.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-23.11     #394   +/-   ##
=============================================
  Coverage         73.35%   73.36%           
=============================================
  Files               385      385           
  Lines             13663    13663           
  Branches           1025     1025           
=============================================
+ Hits              10023    10024    +1     
+ Misses             3640     3639    -1     
Flag Coverage Δ
cpp 69.41% <ø> (+<0.01%) ⬆️
py 41.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d20a3...f5aaf38. Read the comment docs.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 079e371 into nv-morpheus:branch-23.11 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: Create local CI scripts [FEA]: Rebase docker images on rapidsai/ci-conda
2 participants