RxNodeComponent should set exceptions on the context #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagardner-nv
added
bug
Co-authored-by: Michael Demoret <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.07 #326 +/- ##
================================================
- Coverage 73.24% 73.21% -0.04%
================================================
Files 390 390
Lines 13380 13382 +2
Branches 1009 1010 +1
================================================
- Hits 9800 9797 -3
- Misses 3580 3585 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mdemoret-nv
approved these changes
May 10, 2023
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
May 10, 2023
Followup to #326 Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #327
3 tasks
rapids-bot bot
pushed a commit
to nv-morpheus/Morpheus
that referenced
this pull request
May 15, 2023
) * Allows the `MonitorStage` to be placed immediately after stages such as `MultiFileSource` which emits `fsspec.core.OpenFiles` instead of message types. * Adds more tests for `MonitorStage`, some of these test that when the stage does raise a `NotImplementedError` that the pipeline halts propperly which was ultimately fixed in MRC PRs nv-morpheus/MRC#326 and nv-morpheus/MRC#327 fixes #941 Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #942
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows any thrown exceptions to be handled by the runner.
Checklist