Skip to content

Commit

Permalink
Remove unreachable return statements
Browse files Browse the repository at this point in the history
  • Loading branch information
dagardner-nv committed Jan 13, 2025
1 parent 467c07b commit ddffa07
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
4 changes: 0 additions & 4 deletions cpp/mrc/include/mrc/node/sink_properties.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,11 @@ class NullReadableEdge : public edge::IEdgeReadable<T>
channel::Status await_read(T& t) override
{
throw std::runtime_error("Attempting to read from a null edge. Ensure an edge was established for all sinks.");

return channel::Status::error;
}

channel::Status await_read_until(T& t, const mrc::channel::time_point_t& tp) override

Check warning on line 45 in cpp/mrc/include/mrc/node/sink_properties.hpp

View check run for this annotation

Codecov / codecov/patch

cpp/mrc/include/mrc/node/sink_properties.hpp#L45

Added line #L45 was not covered by tests
{
throw std::runtime_error("Attempting to read from a null edge. Ensure an edge was established for all sinks.");

Check warning on line 47 in cpp/mrc/include/mrc/node/sink_properties.hpp

View check run for this annotation

Codecov / codecov/patch

cpp/mrc/include/mrc/node/sink_properties.hpp#L47

Added line #L47 was not covered by tests

return channel::Status::error;
}
};

Expand Down
1 change: 0 additions & 1 deletion cpp/mrc/tests/node/test_nodes.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ class EdgeReadableLambda : public edge::IEdgeReadable<T>
channel::Status await_read_until(T& t, const mrc::channel::time_point_t& tp) override
{
throw std::runtime_error("Not implemented");
return channel::Status::error;
}

private:
Expand Down

0 comments on commit ddffa07

Please sign in to comment.