Skip to content

Commit

Permalink
Ensuring all export sets are using ${PROJECT_NAME}-exports
Browse files Browse the repository at this point in the history
  • Loading branch information
mdemoret-nv committed Dec 22, 2023
1 parent d12e95e commit cfce3d8
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 16 deletions.
20 changes: 10 additions & 10 deletions cmake/dependencies.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ morpheus_utils_initialize_cpm(MRC_CACHE_DIR)
# Start with CUDA. Need to add it to our export set
rapids_find_package(CUDAToolkit
REQUIRED
BUILD_EXPORT_SET ${PROJECT_NAME}-core-exports
INSTALL_EXPORT_SET ${PROJECT_NAME}-core-exports
BUILD_EXPORT_SET ${PROJECT_NAME}-exports
INSTALL_EXPORT_SET ${PROJECT_NAME}-exports
)

# Boost
Expand All @@ -48,8 +48,8 @@ morpheus_utils_configure_rmm()
# ======
rapids_find_package(gflags REQUIRED
GLOBAL_TARGETS gflags
BUILD_EXPORT_SET ${PROJECT_NAME}-core-exports
INSTALL_EXPORT_SET ${PROJECT_NAME}-core-exports
BUILD_EXPORT_SET ${PROJECT_NAME}-exports
INSTALL_EXPORT_SET ${PROJECT_NAME}-exports
)

# glog
Expand All @@ -72,8 +72,8 @@ rapids_find_package(gRPC REQUIRED
gRPC::address_sorting gRPC::gpr gRPC::grpc gRPC::grpc_unsecure gRPC::grpc++ gRPC::grpc++_alts gRPC::grpc++_error_details gRPC::grpc++_reflection
gRPC::grpc++_unsecure gRPC::grpc_plugin_support gRPC::grpcpp_channelz gRPC::upb gRPC::grpc_cpp_plugin gRPC::grpc_csharp_plugin gRPC::grpc_node_plugin
gRPC::grpc_objective_c_plugin gRPC::grpc_php_plugin gRPC::grpc_python_plugin gRPC::grpc_ruby_plugin
BUILD_EXPORT_SET ${PROJECT_NAME}-core-exports
INSTALL_EXPORT_SET ${PROJECT_NAME}-core-exports
BUILD_EXPORT_SET ${PROJECT_NAME}-exports
INSTALL_EXPORT_SET ${PROJECT_NAME}-exports
)

# RxCpp
Expand All @@ -84,8 +84,8 @@ morpheus_utils_configure_rxcpp()
# ======
rapids_find_package(nlohmann_json REQUIRED
GLOBAL_TARGETS nlohmann_json::nlohmann_json
BUILD_EXPORT_SET ${PROJECT_NAME}-core-exports
INSTALL_EXPORT_SET ${PROJECT_NAME}-core-exports
BUILD_EXPORT_SET ${PROJECT_NAME}-exports
INSTALL_EXPORT_SET ${PROJECT_NAME}-exports
FIND_ARGS
CONFIG
)
Expand All @@ -103,7 +103,7 @@ if(MRC_BUILD_BENCHMARKS)
# ================
rapids_find_package(benchmark REQUIRED
GLOBAL_TARGETS benchmark::benchmark
BUILD_EXPORT_SET ${PROJECT_NAME}-core-exports
BUILD_EXPORT_SET ${PROJECT_NAME}-exports

# No install set
FIND_ARGS
Expand All @@ -116,7 +116,7 @@ if(MRC_BUILD_TESTS)
# ===========
rapids_find_package(GTest REQUIRED
GLOBAL_TARGETS GTest::gtest GTest::gmock GTest::gtest_main GTest::gmock_main
BUILD_EXPORT_SET ${PROJECT_NAME}-core-exports
BUILD_EXPORT_SET ${PROJECT_NAME}-exports

# No install set
FIND_ARGS
Expand Down
6 changes: 3 additions & 3 deletions cpp/mrc/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ include(GNUInstallDirs)
install(
TARGETS libmrc
DESTINATION ${lib_dir}
EXPORT ${PROJECT_NAME}-core-exports
EXPORT ${PROJECT_NAME}-exports
COMPONENT Core
)

Expand Down Expand Up @@ -250,7 +250,7 @@ set(rapids_project_version_compat SameMinorVersion)
# Need to explicitly set VERSION ${PROJECT_VERSION} here since rapids_cmake gets
# confused with the `RAPIDS_VERSION` variable we use
rapids_export(INSTALL ${PROJECT_NAME}
EXPORT_SET ${PROJECT_NAME}-core-exports
EXPORT_SET ${PROJECT_NAME}-exports
GLOBAL_TARGETS libmrc
VERSION ${PROJECT_VERSION}
NAMESPACE mrc::
Expand All @@ -261,7 +261,7 @@ rapids_export(INSTALL ${PROJECT_NAME}
# ##################################################################################################
# - build export ----------------------------------------------------------------------------------
rapids_export(BUILD ${PROJECT_NAME}
EXPORT_SET ${PROJECT_NAME}-core-exports
EXPORT_SET ${PROJECT_NAME}-exports
GLOBAL_TARGETS libmrc
VERSION ${PROJECT_VERSION}
LANGUAGES C CXX CUDA
Expand Down
2 changes: 1 addition & 1 deletion protos/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ add_dependencies(${PROJECT_NAME}_style_checks mrc_protos-headers-target)

install(
TARGETS mrc_protos mrc_architect_protos
EXPORT ${PROJECT_NAME}-core-exports
EXPORT ${PROJECT_NAME}-exports
PUBLIC_HEADER
DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/${PROJECT_NAME}/protos"
)
Expand Down
2 changes: 1 addition & 1 deletion python/mrc/_pymrc/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ rapids_cmake_install_lib_dir(lib_dir)
install(
TARGETS pymrc
DESTINATION ${lib_dir}
EXPORT ${PROJECT_NAME}-core-exports
EXPORT ${PROJECT_NAME}-exports
COMPONENT Python
)

Expand Down

0 comments on commit cfce3d8

Please sign in to comment.