Skip to content

chore(npmrc): set shell-emulator to make scripts work on windows #3198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

VisualYuki
Copy link
Contributor

@VisualYuki VisualYuki commented Jan 29, 2025

๐Ÿ”— Linked issue

โ“ Type of change

  • ๐Ÿ“– Documentation (updates to the documentation or readme)
  • ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • ๐Ÿ‘Œ Enhancement (improving an existing functionality)
  • โœจ New feature (a non-breaking change that adds functionality)
  • ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

๐Ÿ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

2025-01-29_10-44-28

Copy link

pkg-pr-new bot commented Jan 29, 2025

npm i https://pkg.pr.new/@nuxt/ui@3198

commit: c88fdb0

@benjamincanac benjamincanac changed the title problem with npm scripts on windows chore(npmrc): set shell-emulator to make scripts work on windows Jan 29, 2025
@benjamincanac
Copy link
Member

Thanks! Didn't know about this option ๐Ÿ˜Š

@benjamincanac benjamincanac merged commit 7299b0c into nuxt:v3 Jan 29, 2025
2 checks passed
@sandros94
Copy link
Member

sandros94 commented Jan 29, 2025

Thanks! Didn't know about this option ๐Ÿ˜Š

me neither ๐Ÿ˜ฎ

(I mainly work on windows)

@MuhammadM1998
Copy link
Contributor

TIL ๐Ÿ‘€ I'm on Windows and was using nuxt dev docs command directly because of this error!

@benjamincanac benjamincanac added the v3 #1289 label Jan 30, 2025
@sandros94
Copy link
Member

I just discovered that this also forces cmd and powershell to not correctly terminate processes when pressing CTRL-C.

This results in node terminating only the parent process but not all the child ones AND lose focus, making the terminal soft-locked.

I'll look into solving both issues, but nothing comes to mind other than removing the env vars from scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants