-
Notifications
You must be signed in to change notification settings - Fork 710
feat(locale): add Hungarian language #3129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): add Hungarian language #3129
Conversation
I'd like to propose implementing linked messages for commonly reused text across our localization files. This approach would help us maintain consistency and reduce duplication in our translations. For example, instead of repeating the same import { defineLocale } from '../composables/defineLocale'
export default defineLocale({
name: '...',
code: '...',
messages: {
common: {
actions: {
close: '...', // Define the translation once
},
},
toast: {
close: '@:common.actions.close', // Reference the common translation
},
}
}) This pattern would make our localization more maintainable since we'd only need to update common phrases in one place. It would also help ensure consistent terminology throughout the interface. What are your thoughts on adopting this approach? |
commit: |
I noticed that Hungarian, like many languages, has multiple ICU locale definitions - both a general language code ( For example, looking at the ICU data:
Should we consider supporting these regional variants in our localization system? While starting with the base language code ( References: |
3f539c3
to
0714305
Compare
0714305
to
c3ea8a5
Compare
magyar ππΊ
c3ea8a5
to
037e9ed
Compare
Thanks for your PR! π Regarding the common messages, I don't think its necessary as there are very few entries. It would make the logic too complex for such a small improvement in my opinion. I'm not sure it's necessary to support all regional variants, if you look at https://ui3.nuxt.dev/getting-started/i18n/nuxt#supported-languages we can see that only variants for different countries have been implemented but I don't know much about other countries needs for locales π¬ Let's merge this and if it's needed someday, we can make another PR! |
magyar ππΊ
π Linked issue
β Type of change
π Description
π Checklist