This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
[Doc EN]: development-tools.md review.
#263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Lesieur <[email protected]>
MachinisteWeb
commented
Sep 28, 2017
| @@ -7,14 +7,15 @@ description: Nuxt.js helps you to make your web development enjoyable. | |||
|
|
|||
| ## End-to-End Testing | |||
|
|
|||
| [Ava](https://github.com/avajs/ava) is a powerful JavaScript testing framework, mixed with [jsdom](https://github.com/tmpvar/jsdom), we can use them to do end-to-end testing easily. | |||
| [AVA](https://github.com/avajs/ava) is a powerful JavaScript testing framework, mixed with [jsdom](https://github.com/tmpvar/jsdom), we can use them to do end-to-end testing easily. | |||
There was a problem hiding this comment.
AVA is in capitalize as mentioned in official documentation
— Source: https://github.com/avajs/ava
| @@ -7,14 +7,15 @@ description: Nuxt.js helps you to make your web development enjoyable. | |||
|
|
|||
| ## End-to-End Testing | |||
|
|
|||
| [Ava](https://github.com/avajs/ava) is a powerful JavaScript testing framework, mixed with [jsdom](https://github.com/tmpvar/jsdom), we can use them to do end-to-end testing easily. | |||
| [AVA](https://github.com/avajs/ava) is a powerful JavaScript testing framework, mixed with [jsdom](https://github.com/tmpvar/jsdom), we can use them to do end-to-end testing easily. | |||
|
|
|||
There was a problem hiding this comment.
Line return like Markdown convention.
| ```bash | ||
| npm install --save-dev ava jsdom | ||
| ``` | ||
|
|
||
| And add a test script to our `package.json` and configure ava to compile files that we import into our tests. | ||
| Then add a test script to our `package.json` and configure AVA to compile files that we import into our tests. |
There was a problem hiding this comment.
AVA in capitalize and « And » to « Then » to avoid repetition with « and » after package.
| @@ -33,11 +34,13 @@ And add a test script to our `package.json` and configure ava to compile files t | |||
| ``` | |||
|
|
|||
| We are going to write our tests in the `test` folder: | |||
|
|
|||
There was a problem hiding this comment.
Line return like Markdown convention.
| ```bash | ||
| mkdir test | ||
| ``` | ||
|
|
||
| Let's say we have a page in `pages/index.vue`: | ||
|
|
There was a problem hiding this comment.
Line return like Markdown convention.
| @@ -58,7 +61,7 @@ export default { | |||
| </style> | |||
| ``` | |||
|
|
|||
| When we launch our app with `npm run dev` and open [http://localhost:3000](http://localhost:3000), we can see our red `Hello world!` title. | |||
| When we launch our app with `npm run dev` and open http://localhost:3000, we can see our red `Hello world!` title. | |||
There was a problem hiding this comment.
Avoid link for all localhost path because in most cases that conduces to 404 page.
| @@ -67,7 +70,7 @@ import test from 'ava' | |||
| import { Nuxt, Builder } from 'nuxt' | |||
| import { resolve } from 'path' | |||
|
|
|||
| // We keep a reference to nuxt so we can close | |||
| // We keep a reference to Nuxt so we can close | |||
| @@ -90,7 +93,7 @@ test('Route / exits and render HTML', async t => { | |||
| t.true(html.includes('<h1 class="red">Hello world!</h1>')) | |||
| }) | |||
|
|
|||
| // Example of testing via dom checking | |||
| // Example of testing via DOM checking | |||
There was a problem hiding this comment.
The DOM is in capitalize.
— Source: https://www.w3.org/DOM/
| @@ -100,13 +103,14 @@ test('Route / exits and render HTML with CSS applied', async t => { | |||
| t.is(window.getComputedStyle(element).color, 'red') | |||
| }) | |||
|
|
|||
| // Close the nuxt server | |||
| // Close the Nuxt server | |||
There was a problem hiding this comment.
Product name.
| test.after('Closing server', t => { | ||
| nuxt.close() | ||
| }) | ||
| ``` | ||
|
|
||
| We can now launch our tests: | ||
|
|
There was a problem hiding this comment.
Line return like Markdown convention.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our French translation/review we have changed some consistent things, so we suggest you do the same in the original documentation.
More details in comments.
Do not hesitate to set back the original behavior for some changes if you think they do not make sense.