Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies & provide client earlier #433

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

felixgabler
Copy link
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  1. Updated some dependencies (incl. @supabase/ssr)
  2. I moved the provide for the client in both plugins before the first await (instead of returning it at the end). This is because we found some Sentry logs that showed one of our plugins with an async setup method not having provided early enough which lead to "Right side of assignment could not be destructured" even though I would have expected that the app only runs once the plugins' setup is finished and everything is provided. Since I made the change, the errors have stopped. @larbish is this necessary or how could the provide have gone wrong in an async context?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Copy link

netlify bot commented Nov 19, 2024

👷 Deploy request for n3-supabase pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e123797

@atinux atinux changed the title Update dependencies & provide client earlier chore: update dependencies & provide client earlier Nov 20, 2024
Copy link
Collaborator

@larbish larbish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@larbish larbish merged commit 6a5bb33 into nuxt-modules:main Nov 20, 2024
1 check passed
@felixgabler felixgabler deleted the fg/dependencies branch December 13, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants