test: prevent build collision #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobbieGoede
force-pushed
the
test/prevent-build-collision
branch
from
17b0de5 to
401a1e6
Compare
BobbieGoede
force-pushed
the
test/prevent-build-collision
branch
from
401a1e6 to
5fb8cf1
Compare
DarthGigi
pushed a commit
to DarthGigi/i18n
that referenced
this pull request
Apr 16, 2024
* test: prevent build collision * test: include directories in test `buildDir`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Our changes to
@nuxt/test-utilsdisabled the random numbered subdirectorybuildDirfor tests, this can cause issues when test threads are enabled (which I did in #2452).This PR changes the behavior to set the
buildDirto a subdirectory based on the test filenames, this should make the tests less flaky. It seems the tests run in a random order, so it may be possible that tests failed as they clear and overwrite the build files of other tests when using the same fixtures.Possibly related to test failures in #2446
📝 Checklist