Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement connect, disconnect and delete operations for nested mutations upon MorphTo relationships #879

Merged
merged 13 commits into from
Aug 7, 2019

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Jul 25, 2019

  • Added or updated tests
  • Added Docs for all relevant versions
  • Updated the changelog

Related Issue/Intent

Allows connecting and disconnecting polymorphic associations for a MorphTo relation using nested mutations.

Changes

Implement connect and disconnect

The GraphQL Specification does not support Input Union types,
for now we are limiting this implementation to connect and disconnect operations.

Let's see which one of the current RFC's makes it and base the implementation of create and update upon that. graphql/graphql-spec#114

Breaking changes

Nope

@spawnia spawnia requested review from alberthaff, chrissm79 and olivernybroe and removed request for chrissm79 August 6, 2019 15:06
Copy link
Contributor

@chrissm79 chrissm79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this one @spawnia 👍

Copy link
Collaborator

@olivernybroe olivernybroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 🎉
Let's hope the RFC gets through soon so we can have create and update also.

Just had one small change to docs.

@spawnia spawnia changed the title Implement connect and disconnect operations for nested mutations upon MorphTo relationships Implement connect, disconnect and delete operations for nested mutations upon MorphTo relationships Aug 7, 2019
@spawnia spawnia merged commit e0ec155 into master Aug 7, 2019
@spawnia spawnia deleted the nested-morph-to branch August 7, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants